Adjust run_make_support::symbols helpers
#143837
Open
+268
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
jieyouxu
commented
Jul 12, 2025
There was a problem hiding this comment.
(Obviously still broken)
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-waiting-on-author
This comment was marked as resolved.
This comment was marked as resolved.
jieyouxu
changed the title
run-make-support::symbols helpersrun_make_support::symbols helpers
Massage the `symbols` helpers to fill out {match all, match any} x
{substring match, exact match}:
| | Substring match | Exact match |
|-----------|----------------------------------------|-------------------------------|
| Match any | `object_contains_any_symbol_substring` | `object_contains_any_symbol` |
| Match all | `object_contains_all_symbol_substring` | `object_contains_all_symbols` |
As part of this, rename `any_symbol_contains` to
`object_contains_any_symbol_substring` for accuracy.
|
Added a meta test. @rustbot review |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massage the
symbolshelpers to fill out {match all, match any} x {substring match, exact match}:object_contains_any_symbol_substringobject_contains_any_symbolobject_contains_all_symbol_substringobject_contains_all_symbolsAs I'd like to use
object_contains_all_symbolsfor #143669.As part of this:
any_symbol_containstoobject_contains_any_symbol_substringfor accuracy, asany_symbol_containsis actually "contains any matching substring".with_symbol_iter.Noticed while working on #143669.
r? @ChrisDenton (or compiler)